Reduce informer sync interval to default 10h #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabdoa2
force-pushed
the
reduce_informer_sync
branch
from
767aca3
to
79261fe
Compare
toelke
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave sets a default informer sync interval of 5m. Prior to 0.7 this has been needed to catch changes in configmaps/secrets which were created after the deployment. We actually used
1mbefore which cause a lot of stress on the API server.Luckily, this is no longer needed. I reduced it to the controller default of 10h.
Guess this issue comment explains it well: kubernetes-sigs/controller-runtime#521 (comment). Since we do not need any periodoc reconcile (anymore) we should reduce it accordingly.
I updated the README to make clear that you probably should not change this unless you run into bugs with stale resources.