Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix flaking tests in Deployment and StatefulSet controllers #49

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

JoelSpeed
Copy link
Collaborator

@JoelSpeed JoelSpeed commented Apr 24, 2019

Introduces an UpdateWithFunc matcher that uses functional updates to retry updates that otherwise may cause a conflict. This should mean fewer flaking tests in the future.

@JoelSpeed
Copy link
Collaborator Author

/retest

@pusher-ci pusher-ci added size/L and removed size/XXL labels Apr 24, 2019
@JoelSpeed JoelSpeed marked this pull request as ready for review April 24, 2019 10:14
@JoelSpeed JoelSpeed requested a review from a team April 24, 2019 10:14
@JoelSpeed
Copy link
Collaborator Author

/retest

Copy link
Contributor

@mthssdrbrg mthssdrbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, less flakes 👍

@JoelSpeed JoelSpeed merged commit 16e2a2a into master Apr 24, 2019
@pusher-ci pusher-ci deleted the update-flakes branch April 24, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants