Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

🎁 Version ranges are automatically used for release images #20

Merged
merged 9 commits into from
Oct 28, 2021
Merged

🎁 Version ranges are automatically used for release images #20

merged 9 commits into from
Oct 28, 2021

Conversation

cardil
Copy link
Member

@cardil cardil commented Oct 26, 2021 •
edited
Loading

Fixes #19

This PR rework how the git version calculates the project version and introduce the way to know if the current version is the latest.

Changes

  • 🎁 Version ranges are automatically used for release images

dsimansk
dsimansk reviewed Oct 26, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
cardil
cardil commented Oct 26, 2021
View reviewed changes
pkg/version/resolver.go Outdated Show resolved Hide resolved
@cardil cardil requested a review from dsimansk October 26, 2021 11:38
cardil added a commit that referenced this pull request Oct 26, 2021
@cardil
Introducing version.Resolver type for compatibility with #20
b341813
@cardil cardil changed the title Feature: Version ranges 🎁 Version ranges calculation for images Oct 26, 2021
@cardil cardil changed the title 🎁 Version ranges calculation for images 🎁 Version ranges are automatically used for release images Oct 26, 2021
mgencur
mgencur reviewed Oct 27, 2021
View reviewed changes
pkg/git/info.go Outdated Show resolved Hide resolved
pkg/git/shell.go Outdated Show resolved Hide resolved
pkg/git/shell.go Outdated Show resolved Hide resolved
pkg/git/version.go Outdated Show resolved Hide resolved
pkg/version/resolver.go Outdated Show resolved Hide resolved
@cardil
Copy link
Member Author

cardil commented Oct 28, 2021

Merging. 🙇 @mgencur & @dsimansk for reviews! Much appreciated!

@cardil cardil merged commit cafaf8e into master Oct 28, 2021
@cardil cardil deleted the bugfix/19-version-ranges branch October 28, 2021 07:50
cardil added a commit that referenced this pull request Oct 29, 2021
@cardil
🎁 Allow to override version via environmental variables to be used on…
0bd3a66 
… CI (#22)

* Introducing version.Resolver type for compatibility with #20

* Impementing knative style version resolver using composite, ordered, and git resolvers.

* Adding additional tests and fixes

* More tests to pinpoint the failure

* Knative version resolver work properly

* Lint fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgencur mgencur mgencur left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve tags ranges from SCM information and allow to use tag ranges in development
3 participants
@cardil @mgencur @dsimansk