Bringing changes from dev downstream to Jaden #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created restaurant class, order class
reserveTable implementation + unit tests
@LOK3LANI please don't commit your build files, your config files, or any auto generated code or self written code that does not relate to this project in any way whatsoever. Rather add this to your gitignore. This was highlighted very clearly in the CONTRIBUTING.md file as can be seen here: https://github.com/waveyboym/COS-214-Project/blob/main/README.md#building-from-the-command-line-with-a-linux-based-osdebian-ubuntu-and-fedora-manually, instruction 15
@LOK3LANI code like this: "else return false" violates our coding guidelines. Refer to this document if you are unsure what the guidelines are: https://github.com/waveyboym/COS-214-Project/blob/develop/Diagrams/Coding%20guidelines/Coding%20Guidelines.pdf
Delete .vscode/settings.json
created restaurant singleton and unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.