This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Adding database middleware with support for readonly db #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for oxcli canceled. 🔨 Explore the source changes: b5af9bb 🔍 Inspect the deploy log: https://app.netlify.com/sites/oxcli/deploys/61673a2d830b68000778fcba |
andrewmkano
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the database middleware with the intention to update Ox applications to use it by default. I used SQLite as the database being used in the tests as its easier to create and connect to it. Also, I decided to put the middleware folder in the root of our package as I asked the Go community and it seems
pkgorlibare not as idiomatic as I thought. If this grow I'm envisioning we will have to move it. For now we're ok.Update:
I decided to update our generated app to use the middleware in this same PR.