This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Fixing #21 #24
Merged
Fixing #21 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for oxcli canceled. 🔨 Explore the source changes: fd6390c 🔍 Inspect the deploy log: https://app.netlify.com/sites/oxcli/deploys/61ab8c48395b7e0008fd9bdd |
|
cc @wawandco/engineering |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21 by installing Buffalo v0.17.x. It changes the names of 2 Afterinitializers that take care of the modules for the new app.
While doing this I feel the urge to write integration tests for all this, which should be one of our priorities, I decided to fix this quicly and test locally, but @YanDeLeon and I have talked about this in the past.