enhance: support access log print cluster prefix #29646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@aoiasd ut workflow job failed, comment |
1 similar comment
|
@aoiasd ut workflow job failed, comment |
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29646 +/- ##
==========================================
- Coverage 83.72% 80.85% -2.88%
==========================================
Files 679 921 +242
Lines 108623 127283 +18660
==========================================
+ Hits 90949 102914 +11965
- Misses 14361 21064 +6703
+ Partials 3313 3305 -8
|
congqixia
reviewed
Jan 5, 2024
| @@ -148,6 +149,14 @@ func (s *GrpcAccessInfoSuite) TestExpression() { | |||
| s.Equal(testExpr, result[0]) | |||
| } | |||
|
|
|||
| func (s *GrpcAccessInfoSuite) TestClusterPrefix() { | |||
| cluster := "instance-test" | |||
| paramtable.Init() | |||
There was a problem hiding this comment.
NIT: put init into SetupSuite
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aoiasd, congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aoiasd
added a commit
to aoiasd/milvus
that referenced
this pull request
Jan 10, 2024
relate: milvus-io#29645 Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate: #29645