Skip to content

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Dec 9, 2014

Made some stuff flake8-compliant.

Before:

❯ tox -e flake8
GLOB sdist-make: /Users/marca/dev/git-repos/Python-Markdown/setup.py
flake8 inst-nodeps: /Users/marca/dev/git-repos/Python-Markdown/.tox/dist/Markdown-2.6.dev.zip
flake8 runtests: PYTHONHASHSEED='1581807905'
flake8 runtests: commands[0] | flake8 /Users/marca/dev/git-repos/Python-Markdown/markdown /Users/marca/dev/git-repos/Python-Markdown/tests /Users/marca/dev/git-repos/Python-Markdown/setup.py /Users/marca/dev/git-repos/Python-Markdown/run-tests.py
/Users/marca/dev/git-repos/Python-Markdown/markdown/util.py:18:19: F821 undefined name 'basestring'
/Users/marca/dev/git-repos/Python-Markdown/markdown/util.py:19:17: F821 undefined name 'unicode'
/Users/marca/dev/git-repos/Python-Markdown/markdown/util.py:20:15: F821 undefined name 'unichr'
/Users/marca/dev/git-repos/Python-Markdown/setup.py:62:22: E211 whitespace before '('
/Users/marca/dev/git-repos/Python-Markdown/setup.py:65:22: E211 whitespace before '('
/Users/marca/dev/git-repos/Python-Markdown/setup.py:150:18: E211 whitespace before '('
/Users/marca/dev/git-repos/Python-Markdown/setup.py:177:34: E211 whitespace before '('
ERROR: InvocationError: '/Users/marca/dev/git-repos/Python-Markdown/.tox/flake8/bin/flake8 /Users/marca/dev/git-repos/Python-Markdown/markdown /Users/marca/dev/git-repos/Python-Markdown/tests /Users/marca/dev/git-repos/Python-Markdown/setup.py /Users/marca/dev/git-repos/Python-Markdown/run-tests.py'
___________________________________________________________________________________ summary ____________________________________________________________________________________
ERROR:   flake8: commands failed

After:

❯ tox -e flake8
GLOB sdist-make: /Users/marca/dev/git-repos/Python-Markdown/setup.py
flake8 inst-nodeps: /Users/marca/dev/git-repos/Python-Markdown/.tox/dist/Markdown-2.6.dev.zip
flake8 runtests: PYTHONHASHSEED='3348188633'
flake8 runtests: commands[0] | flake8 /Users/marca/dev/git-repos/Python-Markdown/markdown /Users/marca/dev/git-repos/Python-Markdown/tests /Users/marca/dev/git-repos/Python-Markdown/setup.py /Users/marca/dev/git-repos/Python-Markdown/run-tests.py
___________________________________________________________________________________ summary ____________________________________________________________________________________
  flake8: commands succeeded
  congratulations :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cedc184 on msabramo:flake8 into 4cac4ff on waylan:master.

@waylan
Copy link
Member

waylan commented Dec 9, 2014

Strange, I was not getting those errors. Changes still needed to be made. Thanks for doing the work.

waylan added a commit that referenced this pull request Dec 9, 2014
@waylan waylan merged commit 99fe8e2 into Python-Markdown:master Dec 9, 2014
@msabramo msabramo deleted the flake8 branch January 30, 2015 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants