Skip to content

Conversation

ParthKolekar
Copy link

When I make a markdown message in the form of 4-space indent.

    <4 spaces>test

The output is shown in the form of

    <pre><code>test</code></pre>

This breaks some tagging in the wikimedia editor which I am using. (Quite an old version.). It interprets the nested code tag as <code>

Simply inverting this should make it work again.

When I make a markdown message in the form of 4-space indent. 

        <4 spaces>test

The output is shown in the form of 

        <pre><code>test</code></pre>

This breaks some tagging in the wikimedia editor which I am using. (Quite an old version.). It interprets the nested code  tag as `<code>`

Simply inverting this should make it work again.
@waylan
Copy link
Member

waylan commented Mar 3, 2016

Are you suggesting that the output should be:

 <code><pre>test</pre></code>

If so, that is not valid Markdown output as defined in the rules. For that matter it is not valid HTML as per the HTML5 Spec either. Perhaps I am misunderstanding what you are trying to accomplish here.

@waylan
Copy link
Member

waylan commented Mar 3, 2016

I just took another look at your change and you don't actually change anything except the variable names. It is not clear how that makes any difference. Nor do I understand what you are trying to accomplish. Could you please provide the input, the desired output and the actual output.

@ParthKolekar
Copy link
Author

Yes. I completely misinterpreted the code and missed the point of changing variable names and tag type. If it is not a valid HTML5 spec, then I think I should try to hack about in the old wikimedia entry rather than here.

This PR is then invalid.

@ParthKolekar ParthKolekar deleted the patch-1 branch March 3, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants