Skip to content

Conversation

cyriac
Copy link

@cyriac cyriac commented May 3, 2016

markdownFromFile() function currently doesn't return the converted markdown. Adding return to make the converted markdown available to the caller.

@waylan
Copy link
Member

waylan commented May 3, 2016

markdownFromFile() function currently doesn't return the converted markdown.

...which is by design. In fact, the function already writes the converted Markdown to the output file. Why should it output to two locations at once? As the documentation states:

If this rather naive solution does not meet your specific needs, it is suggested that you write your own code to handle your ... needs.

Besides, your change still doesn't return the converted HTML. It returns the instance of the Markdown class, which does not retain the output.

Regardless, given that this was never the intended use case for this function and in all the years you are the first to ever request such a change, I'm going to say no.

@cyriac
Copy link
Author

cyriac commented May 3, 2016

Yes, I overlooked the entire thing. My changes don't make sense based on your notes.

@cyriac cyriac closed this May 3, 2016
@cyriac cyriac deleted the cyriac-patch-1 branch November 19, 2016 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants