Skip to content

Conversation

buaabyl
Copy link

@buaabyl buaabyl commented Aug 5, 2016

Add a config option 'css_class' to tables.py.

@waylan
Copy link
Member

waylan commented Aug 5, 2016

Thanks for your submission, however, we are currently in a feature freeze as we work toward version 3.

That said, I still have a few concerns. For starters, the tests were not updated and are failing. Second, the default behavior should remain as it was before this change (do not add a class unless the user specifically provides one). And third, I'm having a hard time seeing the value. As all tables in a document will all receive the same class, you can just select all table elements (from CSS or JavaScript). And if you have other tables in your page template (not from the Markdown document), just wrap the Markdown output in a container and select all child table elements of that container. Without a clear use-case, I'm inclined to reject this.

@buaabyl
Copy link
Author

buaabyl commented Aug 6, 2016

because pygment hightlight using table, and have the same level of other tables, so the wrap not help. I use markdown to write user manual. Tables have different style from highlight table. So I add a custom class to table.

@buaabyl buaabyl closed this Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants