Skip to content

Conversation

Larivact
Copy link

The current implementation using these placeholders seems very weird. Am I missing something?

@Larivact
Copy link
Author

@waylan What do you think?

@waylan
Copy link
Member

waylan commented Aug 13, 2016

Thanks for your work on this. I haven't had an opportunity to look at this closely. I wouldn't be surprised if some old code was around that was unnecessary in the footnotes extension. That extension has existed since before I was involved in the project and is one of the few pieces of code I haven't given much attention to (my changes have always been the minimum required to keep it working).

Regardless, as we move to version 3.0 I was expecting to do a complete rewrite of this extension and am not eager to start making changes before then. In fact, we are actually in a feature freeze right now (while working toward 3.0) and I am only interested in fixing bugs in the 2.x branch. So unless this fixes a clearly defined bug, I'll wait till I start refactoring this extension for 3.0. If you're interested, you can review the 3.0 Roadmap on the wiki.

@waylan waylan added this to the Version 3.0 milestone Jan 19, 2017
@waylan
Copy link
Member

waylan commented Jul 24, 2018

I don't consider this to be "unnessecary". Note that inline parsing can muck up HTML entities. Therefore, it is less likely to break things if we use placeholders. See the discussion to #493 where one of those placeholders was added. If the tests pass after removing the placeholders, then that is more likely an indication that we have incomplete tests than anything else.

@waylan waylan closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants