Skip to content

Conversation

adamchainz
Copy link
Contributor

By releasing as a Python wheel as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run python setup.py clean sdist bdist_wheel upload.

By releasing as a [Python wheel](http://pythonwheels.com/) as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run `python setup.py clean sdist bdist_wheel upload`.
@waylan waylan added this to the Version 3.0 milestone Oct 13, 2016
@waylan
Copy link
Member

waylan commented Oct 13, 2016

Thanks for your contribution. This is planned for version 3.0. Version 2 is currently in maintenance mode and only accepting bug fixes at this time. I'll leave this open to remind us to do this for version 3.

@adamchainz
Copy link
Contributor Author

Cool thanks

@benjaoming
Copy link
Contributor

This change doesn't affect the codebase, but I think setup.py looks fairly advanced and would require special testing on at least Windows in order to see that the .whl can still be installed. Python-Markdown doesn't use data_files for setup() which would definitely break.

@waylan I don't think you should push it all the way to 3.0 but maybe introduce it in the 2.7 series?

@waylan
Copy link
Member

waylan commented Dec 28, 2016

@benjaoming there will be no 2.7 series. Which is why I'm rejecting all changes which are more than simple bugfixes. All such work should be on the 3.0 branch (see the Roadmap for details).

@benjaoming
Copy link
Contributor

benjaoming commented Dec 28, 2016

@benjaoming there will be no 2.7 series.

Ah okay, well that would have been another amendment to the release notes ;)

@jdufresne
Copy link
Contributor

You could include the license file in the generated wheel using the license_file in setup.cfg:

[metadata]
license_file = LICENSE.md

See the documentation for information on this feature of wheel:

https://wheel.readthedocs.io/en/stable/#including-the-license-in-the-generated-wheel-file

This would satisfy the license's requirement:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

@waylan
Copy link
Member

waylan commented Dec 10, 2017

This was addressed in #606.

@waylan waylan closed this Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants