Fix Issue #449 and Issue #521 #522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point the logic of counting backtics and determining if they are odd or even was used to parse a row's text into cells. Unfortunately this approach broke expected code parsing logic in a table. We essentially traded one bug for another. This fixes table backtick handling and restores sane backtick logic while preserving existing fixes.
Travis should checkout aspell-en
One thing got overlooked. Backslashes don't quite work the same on backtics. To keep the same feel as code outside the table, we need to account for backslash and backtics the same.
|
Sorry for the multiple commits. I had forgotten that inline code is evaluated before escapes. With squash and merge I might be okay, but if you need a rebase anyways, let me know. |
|
I'd prefer the different things to be in different commits. If you could rebase that would be preferred. |
|
Will do. I kind of figured, but I was hoping :). |
|
Close for rebase. |
|
New pull requests are: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the logic of counting backtics and determining if they
are odd or even was used to parse a row's text into cells.
Unfortunately this approach broke expected code parsing logic in a
table. We essentially traded one bug for another. This fixes table
backtick handling and restores sane backtick logic while preserving
existing fixes. (Another table and inline code issue #449)
Travis should checkout aspell-en (FYI: Spelling silently failing in Travis #521)