Better handling of backticks #524
Conversation
tests/extensions/extra/tables.txt
Outdated
|
|
||
| Add tests for issue #449 | ||
|
|
||
| Odd backtics | Even backtics |
There was a problem hiding this comment.
Backticks (also in the commit message).
There was a problem hiding this comment.
I can update the test, but I don't think there is any thing I can do about the commit message though.
There was a problem hiding this comment.
Why? git commit --amend && git push --force.
There was a problem hiding this comment.
Wasn't sure how that affects the pull as I think GitHub uses the message to calculate the hash. Good to know it can be done. I'll take care of it.
There was a problem hiding this comment.
Done. Commit update worked great, thanks for letting me know. I was under the incorrect assumption that GitHub didn't support it. Wish I had know about this sooner :).
There was a problem hiding this comment.
Just a note for your future PRs: you could also squash the two commits into a single one by using git commit -a --amend (or git add && git commit --amend). Sorry for not being so precise in my previous reply.
There was a problem hiding this comment.
Though @waylan probably uses GitHub UI for merging pull requests, and that UI has an option to squash all commits and edit the message, anyway :)
There was a problem hiding this comment.
Just a note for your future PRs: you could also squash the two commits into a single one by using git commit -a --amend (or git add && git commit --amend). Sorry for not being so precise in my previous reply.
Oh. That makes sense. I'm clearly not a git command line warrior; I use the GitHub app to manage my workflow (and it is very limited compared to other git GUIs). I should really play with this more and work it into my workflow. Getting out of my comfort zone and learning git better could really help.
Though @waylan probably uses GitHub UI for merging pull requests, and that UI has an option to squash all commits and edit the message, anyway :)
I hope so. Hoping to avoid another rebase :).
At some point the logic of counting backticks and determining if they are odd or even was used to parse a row's text into cells. Unfortunately this approach broke expected code parsing logic in a table. We essentially traded one bug for another. This fixes table backtick handling and restores sane backtick logic while preserving existing fixes. (issue #449)
At some point the logic of counting backticks and determining if they
are odd or even was used to parse a row's text into cells.
Unfortunately this approach broke expected code parsing logic in a
table. We essentially traded one bug for another. This fixes table
backtick handling and restores sane backtick logic while preserving
existing fixes. (issue #449)