Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description Only line items #106

Closed
robzolkos opened this issue Oct 5, 2013 · 3 comments
Closed

Description Only line items #106

robzolkos opened this issue Oct 5, 2013 · 3 comments

Comments

@robzolkos
Copy link

Is it possible to add line items that are description only?

I use the invoice.add_line_item and omit unit_amount and quantity. These are still sent through as 0.00 and 1 respectively (default values I guess).

API Docs say " A line item with just a description (i.e no unit amount or quantity) can be created by specifying just a element that contains at least 1 character"

@waynerobinson
Copy link
Owner

I have been meaning to take out some of the automated line total calculation code because it causes some problems, just a little worried about anyone who may rely on it existing.

@robzolkos
Copy link
Author

Perhaps there could be an option to keep the existing functionality by default, but opt out so that it doesn't sent the unit amount or quantity if 0.

@waynerobinson
Copy link
Owner

That's not a bad solution. Happy to merge a PR.

It will take me a while to get to this list unfortunately at the moment
given the rest of life getting in the way.

On 15 October 2013 09:46, Rob Zolkos notifications@github.com wrote:

Perhaps there could be an option to keep the existing functionality by
default, but opt out so that it doesn't sent the unit amount or quantity if
0.


Reply to this email directly or view it on GitHubhttps://github.com//issues/106#issuecomment-26295291
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants