Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/modular page tweaks #665

Closed
wants to merge 14 commits into from
Closed

Feature/modular page tweaks #665

wants to merge 14 commits into from

Conversation

chrispelzer
Copy link
Member

No description provided.

@chrispelzer chrispelzer requested a review from a team as a code owner October 24, 2023 21:56
@chrispelzer chrispelzer temporarily deployed to build October 24, 2023 21:56 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 24, 2023 •
edited
Loading

Coverage Status

coverage: 100.0% (+1.7%) from 98.252% when pulling ebd0312 on feature/modular-page-tweaks into ad932ec on develop.

nickdenardis
nickdenardis approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

breakdancingcat
breakdancingcat approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@breakdancingcat breakdancingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beautiful

@chrispelzer
Correct if they don't pass in id or configuration needed to pass in t…
8ef349d 
…he data to return an empty array for the data
@chrispelzer chrispelzer temporarily deployed to build October 25, 2023 13:30 — with GitHub Actions Inactive
@chrispelzer chrispelzer temporarily deployed to build October 25, 2023 15:39 — with GitHub Actions Inactive
@chrispelzer chrispelzer deleted the feature/modular-page-tweaks branch October 26, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breakdancingcat breakdancingcat breakdancingcat approved these changes

@nickdenardis nickdenardis nickdenardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrispelzer @coveralls @nickdenardis @breakdancingcat