Hotfix/8.8.3 - Enhanced text-overlay design on mobile to match hero-half #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breakdancingcat
temporarily deployed
to
build
GitHub Actions
Inactive
breakdancingcat
temporarily deployed
to
build
GitHub Actions
Inactive
Fw7424
approved these changes
Feb 15, 2024
tomkrupka3
approved these changes
Feb 15, 2024
| @yield('hero-buttons') | ||
| </div> | ||
| <{{ !empty($hero['link']) ? '/a' : '/div' }}> |
There was a problem hiding this comment.
Feel like the tradeoff of the performance of this isn't worth the inconsistency with splitting this tag up.
Could we stick to full tags here?
{{ !empty($hero['link']) ? '</a>' : '</div>' }}
| @if(!empty($hero['description'])) | ||
| {!! $hero['description'] !!} | ||
| @if(!empty($hero['link'])) | ||
| {!! preg_replace(array('"<a href(.*?)>"', '"</a>"'), array('',''), $hero['description']) !!} |
There was a problem hiding this comment.
Looks like we're starting to do more than display in the templates. Let's take a look at long-term moving some of this content formatting into the controllers/repositories before it gets to Blade to display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed Text-overlay mobile design was lacking, mirrored to the half-hero mobile appearhance (without a bold title)