Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/8.8.4 - Need base version in the header on sites, not 'version' #696

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

breakdancingcat
Copy link
Member

After upgrading another site and seeing that site's version in the header and not the version of Base, I realized I needed 'base version' not 'version'

@coveralls
Copy link

coveralls commented Feb 16, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 6076340 on hotfix/8.8.4
into 027e0fe on master.

Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

… we can address the scripts that move version to base version when setting up a new site
@breakdancingcat breakdancingcat merged commit 2d0013e into master Feb 16, 2024
2 checks passed
@breakdancingcat breakdancingcat deleted the hotfix/8.8.4 branch February 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants