Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command list-highlighted-annotations doesn't work #35

Open
DanielJoyce opened this issue May 9, 2017 · 20 comments
Open

command list-highlighted-annotations doesn't work #35

DanielJoyce opened this issue May 9, 2017 · 20 comments

Comments

@DanielJoyce
Copy link

DanielJoyce commented May 9, 2017

I have todos and fixmes in my code, and they are highlighted properly. But when I try and list them from the command pallette, it says none were found

@wayou
Copy link
Owner

wayou commented May 13, 2017

More info is needed.
One possible reason I can think of is that the count of files within your project exceeded the limit of this extension.
Try tune the todohighlight.maxFilesForSearch configuration.

@julianblk
Copy link

Hi, I'm having the same issue (I set todohighlight.maxFilesForSearch: 512000). The command starts ok and goes really fast to 99% and then stays there forever. I 'm not seeing any output either:

todohighlight

@wayou
Copy link
Owner

wayou commented May 19, 2017

I wonder if this still exists in the latest version.

@haolly
Copy link

haolly commented May 20, 2017

@wayou Yes, it's still exists in the lastest version, 0.5.3

@Overboard
Copy link

@wayou I see a similar symptom in a simplified reproduction. The List Highlighted Annotations command doesn't stop at 99% as mentioned above, but does fail to return any results. The status bar shows '0', and when clicked Info: No results is shown.

Image of installed extensions, and VSCode version. The settings.json file is all defaults.

todo_highlight_no_list_01

Upon clicking the List annotations icon in status bar:
image

@csbatista
Copy link

csbatista commented Jun 26, 2017

I'm having the same issue on VS Code 1.13.1
I've tried with a project of only one file and it also does not work.
Is there any fix for this?

UPDATE: It works in a javascript project, but not on a python one.

@Overboard
Copy link

Overboard commented Jun 26, 2017

Ah! I just noticed there's no *.py in the defaults for "todohighlight.include".
Thanks for pointing me in the right direction, @csbatista

@KamasamaK
Copy link

For me, the list only works for "ALL". If I choose "TODO:" or "FIXME:", it shows an info message that says "No results".

@wayou
Copy link
Owner

wayou commented Nov 23, 2017

@DanielJoyce what's your configuration?

@anonaut
Copy link

anonaut commented Feb 28, 2018

i got the same problem when i tried to list highlights in files with the filetype .vba and add that to "todohighlight.include". it highlights both keywords as it should but listing is gives back zero results. is there a limitation on which languages the extension works?

example comment would be: ' TODO: Test Discount Features

@wayou
Copy link
Owner

wayou commented Jul 21, 2018

erm...I bet this's been solved in the new version.
waiting anyone to confirm and feedback.

@KamasamaK
Copy link

KamasamaK commented Jul 21, 2018

Using VS Code 1.25.1

In my minimal testing, this is working for List annotations in current file...

However, when selecting List all annotations... it is not finding any regardless of what I choose. The output shows "Searched 12 file(s), found 0 annotation(s)." which is wrong since I have many more than 12 files. The only setting I've overridden is the following

"todohighlight.exclude": [
    "**/node_modules/**",
    "**/bower_components/**",
    "**/dist/**",
    "**/build/**",
    "**/.vscode/**",
    "**/.github/**",
    "**/_output/**",
    "**/*.min.*",
    "**/*.map",
    "**/.next/**",
    "**/out/**"
  ]

Also, despite enabling todohighlight.toggleURI as instructed, the links are still not clickable.

@KamasamaK
Copy link

After looking at the Developer Tools console, I found that it encountered an error when trying to read a .png file and probably stopped there. I added "**/*.png" to the todohighlight.exclude array in my settings and it seems to have fixed the issue for me. Although there are surely other file types might cause this issue.

@wayou
Copy link
Owner

wayou commented Jul 21, 2018

after v1.0.0 all file types are include by default and none support binary file will be skipped.
but the error I still print it out.
so basically if you are using the latest version of this extension, the png wont stop the searching process.

@KamasamaK
Copy link

KamasamaK commented Jul 21, 2018

I am using v1.0.0. I updated before testing.

UPDATE: Actually, it was v1.0.1

@wayou
Copy link
Owner

wayou commented Jul 21, 2018

The output shows "Searched 12 file(s), found 0 annotation(s)." which is wrong since I have many more than 12 files.

note that the git ignored files (defined in .gitignore) will not be include .

@wayou
Copy link
Owner

wayou commented Jul 21, 2018

I am using v1.0.0. I updated before testing.

ok, i will look into a bit further.

@KamasamaK
Copy link

note that the git ignored files (defined in .gitignore) will not be include .

This is not what caused the issue, but is good to know nonetheless. This should be documented in the README and should probably have a setting.

@wayou
Copy link
Owner

wayou commented Jul 21, 2018

This is not what caused the issue, but is good to know nonetheless. This should be documented in the README and should probably have a setting.

I even don't know after debugging with the api vscode.workspace.findFiles. So it's the the api behavior and I think it's reasonable.

@odiferousmint
Copy link

odiferousmint commented Feb 25, 2019

Also, despite enabling todohighlight.toggleURI as instructed, the links are still not clickable.

Same issue here. Installed it today, the links are not clickable.

Edit: never mind, they are. You just have to hold Ctrl when left clicking! Silly me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants