Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST as method of the API login endpoint #751

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

mcarmona99
Copy link
Contributor

This PR closes #713.

In this pull request, I have changed the method used when requesting the API login endpoint from GET to POST because as it was said in the related issue, the actual login endpoint (GET) is going to be deprecated.

@mcarmona99 mcarmona99 self-assigned this Apr 26, 2022
@mcarmona99 mcarmona99 changed the base branch from master to 4.4 August 2, 2022 11:27
@mcarmona99 mcarmona99 requested a review from okynos August 2, 2022 11:27
okynos
okynos previously approved these changes Aug 2, 2022
@okynos okynos requested a review from teddytpc1 August 2, 2022 12:04
teddytpc1
teddytpc1 previously approved these changes Aug 2, 2022
@davidjiglesias davidjiglesias merged commit e91893c into 4.4 Oct 5, 2022
@davidjiglesias davidjiglesias deleted the feature/713-post-api-login branch October 5, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HTTP method to POST when using the API login endpoint
4 participants