Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify repo variables and update repo logic. #753

Merged
merged 6 commits into from
May 4, 2022
Merged

Unify repo variables and update repo logic. #753

merged 6 commits into from
May 4, 2022

Conversation

teddytpc1
Copy link
Member

@teddytpc1 teddytpc1 commented Apr 26, 2022 •
edited
Loading

This PR closes #752.
This was tested with the production deployment using:

  • 6 Centos 8 instances.
  • 2 RHEL 8 , 2 Ubuntu Focal and 2 Amazon Linux instances.

The Demo deployment worked using this Ansible branch and Automation branch 752-unify-repos:

@teddytpc1 teddytpc1 self-assigned this Apr 26, 2022
@teddytpc1 teddytpc1 marked this pull request as draft April 26, 2022 20:23
@teddytpc1 teddytpc1 marked this pull request as ready for review April 26, 2022 20:54
vcerenu
vcerenu previously approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@vcerenu vcerenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

okynos
okynos previously approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@okynos okynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teddytpc1 teddytpc1 dismissed stale reviews from okynos and vcerenu via acec963 May 3, 2022 19:06
vcerenu
vcerenu approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@vcerenu vcerenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alberpilot
alberpilot approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberpilot alberpilot merged commit 4955270 into 4.3 May 4, 2022
@alberpilot alberpilot deleted the 4.3-unify-repo branch May 4, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcerenu vcerenu vcerenu approved these changes

@alberpilot alberpilot alberpilot approved these changes

@okynos okynos okynos left review comments

Assignees

@teddytpc1 teddytpc1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teddytpc1 @alberpilot @okynos @vcerenu