Moved custom_ruleset files #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SitoRBJ
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Hello @cadoming and @paulcalabro,
We have successfully tested the changes.
Thank you very much for your collaboration and for your contribution. We proceed to merge the code.
Best regards,
Alfonso Ruiz-Bravo
|
The path must be relative instead of absolute. Please, change it. |
|
Hi @jesuslinares and @paulcalabro, I have done a commit to change the path like @jesuslinares just say. Regards, |
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @paulcalabro,
I created this PR from yours #94 , the only difference is that it points to branch 3.7. I have tested the changes you propouse and it work fine. Thank you for your work.
Regards,
Carlos