New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No id on kbn-vis #275

Merged

havidarou merged 2 commits into 3.2 from 3.2-no-id-patch

Feb 26, 2018

Contributor

jesusgn90 commented Feb 23, 2018

Hi team this PR makes a little fix on the visualization directive and now it's no longer neccessary the id field when using a kbn-vis element.
Also all kbn-vis elements have no id field now.

Jesús Ángel González added 2 commits

February 23, 2018 14:49


          New way to look at the vis

d1b13eb


          Removed id field from all visualizations

32a4fd5

Member

havidarou commented Feb 26, 2018

LGTM!

havidarou merged commit aba48e8 into 3.2

havidarou deleted the 3.2-no-id-patch branch

February 26, 2018 10:34

JuanjiJG added a commit that referenced this pull request


          Update CHANGELOG.md for #274 and #275

b4d1f9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet