Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status pending agents #3095

Merged
merged 5 commits into from
Apr 5, 2021
Merged

Add status pending agents #3095

merged 5 commits into from
Apr 5, 2021

Conversation

pablomarga
Copy link
Contributor

@pablomarga pablomarga commented Mar 23, 2021 •
edited
Loading

Hi team this PR resolves:

  • Missing pending option for field status in Agents overview

Closes #3067

Captura de pantalla 2021-03-23 a las 11 29 08
Captura de pantalla 2021-03-23 a las 11 19 39
Captura de pantalla 2021-03-23 a las 11 19 13

@pablomarga pablomarga requested a review from a team March 23, 2021 10:00
@pablomarga pablomarga self-assigned this Mar 23, 2021
Desvelao
Desvelao reviewed Apr 5, 2021
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 5 to 11
## Wazuh v4.1.3 - Kibana 7.10.0 , 7.10.2 - Revision 4105

### Added

- Pending status suggestion for agents [#3095](https://github.com/wazuh/wazuh-kibana-app/pull/3095)

## Wazuh v4.1.3 - Kibana 7.10.0 , 7.10.2 - Revision 4104
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be updated to 4.2.0-4201.

@Desvelao
Copy link
Member

Desvelao commented Apr 5, 2021 •
edited
Loading

Edit: Should we add the suggestions alphabetically sorted?
image

@pablomarga pablomarga changed the base branch from 4.1-7.10 to 4.2-7.10 April 5, 2021 16:49
@pablomarga
Copy link
Contributor Author

Should we add the suggestions alphabetically sorted?
image

It is already alphabetically sorted

frankeros
frankeros approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 276bc26 into 4.2-7.10 Apr 5, 2021
@frankeros frankeros deleted the fix/add-status-pending-agents branch April 5, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@frankeros frankeros frankeros approved these changes

Assignees

@pablomarga pablomarga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablomarga @Desvelao @frankeros