[Refactor] Table in Vulnerabilities/Inventory
#3196
Conversation
| isExpandable={true} | ||
| rowProps={getRowProps} | ||
| error={error} | ||
| sorting={sorting} |
There was a problem hiding this comment.
Why pass the sorting props to the component. The component should control by itself the sorting state.
There was a problem hiding this comment.
I forgot delete this prop.
| title='Vulnerabilities' | ||
| tableColumns={columns} | ||
| tableInitialSortingField='name' | ||
| searchTable={true} |
There was a problem hiding this comment.
This prop adds a search bar to the table but the component is called TableWithSearchBardWzAPI. We should rename the component if it can have a search bar or not, or create differents components (with the search bar or not).
There was a problem hiding this comment.
Yes, I'm renaming the component to TableWzAPI
| searchTable={true} | ||
| searchBarSuggestions={this.suggestions} | ||
| endpoint={`/vulnerability/${this.props.agent.id}`} | ||
| reload={isLoading} |
There was a problem hiding this comment.
The reload prop in the original table, redo the request with the current table status, when reload prop change.
|
I was testing the PR with another Wazuh manager branch and I found when exporting to CSV, there columns are missing and the CSV columns are not in the same order that the table in the app. |
frankeros
deleted the
feature/add-status-and-type-in-vulnerabilities-table
branch
Desvelao
changed the title
Vulnerabilities/Inventory
Hi team, this resolve:
How to test:
Closes #3093