Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid huge logs #3397

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Avoid huge logs #3397

merged 5 commits into from
Jun 30, 2021

Conversation

frankeros
Copy link
Contributor

@frankeros frankeros commented Jun 24, 2021 •
edited
Loading

Hi team, this resolves:

  • Avoid huge logs when messages or objects are too long.

Testing:
Turn down the Wazuh API when the cron job for statistics is waiting for the response at server/start/cron-scheduler/scheduler-job,ts#run()

Closes #3388

gabiwassan
gabiwassan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pablomarga
pablomarga approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Desvelao
Desvelao reviewed Jun 30, 2021
View reviewed changes
server/lib/logger.ts Outdated Show resolved Hide resolved
Desvelao
Desvelao requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: Review the suggested request changes

@frankeros frankeros merged commit 052a47f into 4.2-7.10 Jun 30, 2021
@frankeros frankeros deleted the bugfix/3388-avoid-huge-logs branch June 30, 2021 20:42
frankeros added a commit that referenced this pull request Jun 30, 2021
@frankeros
cherry-pick: #3397
de62245
@frankeros frankeros mentioned this pull request Jun 30, 2021
Merged
frankeros added a commit that referenced this pull request Jul 2, 2021
@frankeros
Cherry pick #3397 into 4.3 7.10 (#3419)
3e96b3e 
* cherry-pick: #3397

* fix: wrong property in parsedData
@MauGaP MauGaP mentioned this pull request Sep 1, 2021
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao requested changes

@pablomarga pablomarga pablomarga approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frankeros @gabiwassan @Desvelao @pablomarga