fix size api selector and add basic test #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpRegalado
suggested changes
Jul 8, 2021
public/components/wz-menu/wz-menu.js
Outdated
| @@ -632,7 +632,7 @@ export const WzMenu = withWindowSize(class WzMenu extends Component { | |||
| } | |||
|
|
|||
| getApiSelectorComponent() { | |||
| let style = { maxWidth: 100 }; | |||
| let style = { minWidth: 'max-content' }; | |||
There was a problem hiding this comment.
increasing the size the component can take is a good first step, but not limiting it in any way can lead to other issues, if the name is too long still, the other components in the menu will be squished and rendered incorrectly
I suggest you specify a max size and text-overflow: ellipsis
There was a problem hiding this comment.
It is a very difficult case to happen (that the api name is so long) but I will consider it.
eze9252
deleted the
bugfix/3334-api-selector-breaks-when-api-name-is-long
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, this resolves:
How to Test:
Closes #3334