Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement try catch in Components > Wz files #3448

Merged
merged 9 commits into from
Jul 20, 2021
Merged

Implement try catch in Components > Wz files #3448

merged 9 commits into from
Jul 20, 2021

Conversation

pablomarga
Copy link
Contributor

Hi team,
This PR implement our new error handling strategy on the wz files in components section

Close #3447

@pablomarga pablomarga self-assigned this Jul 7, 2021
@Desvelao Desvelao linked an issue Jul 8, 2021 that may be closed by this pull request
Refactor try catch in Wz files in Components #3447
Closed
gabiwassan
gabiwassan approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabiwassan gabiwassan merged commit 7f672af into 4.3-7.10 Jul 20, 2021
@gabiwassan gabiwassan deleted the implement/try-catch-wz-files branch July 20, 2021 17:03
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.6% ( 1281 / 35624 )
Branches 1.43% ( 401 / 28027 )
Functions 2.48% ( 214 / 8632 )
Lines 3.63% ( 1236 / 34044 )

gabiwassan added a commit that referenced this pull request Jul 30, 2021
@pablomarga @gabiwassan @Machi3mfl
Implement try catch in Components > Wz files (#3448)
9591bc8 
* Implement try catch wz files in components

* Fix useEffect

* Update changelog

* Solve comments

* Change some error display options

Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
@pablomarga @gabiwassan @Machi3mfl
Implement try catch in Components > Wz files (#3448)
d87b6cb 
* Implement try catch wz files in components

* Fix useEffect

* Update changelog

* Solve comments

* Change some error display options

Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankeros frankeros frankeros left review comments

@Desvelao Desvelao Desvelao left review comments

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@pablomarga pablomarga

Labels
error-handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor try catch in Wz files in Components
5 participants
@pablomarga @gabiwassan @frankeros @Desvelao @Machi3mfl