Wrong active-response endpoint parameter from dev tools #3466

sortiz1191 · 2021-07-13T13:50:49Z

Hi team!
This PR solves an error when trying to send an array to an /active-response path.
Before the change, the request retrieved the next error with this example:

EXAMPLE:
PUT /active-response?agents_list=000 { "arguments": [ "-","1.1.1.1" ], "command":"firewall-drop.sh", "custom": true }
ERROR:
error: 2021/07/12 15:32:7: wazuh-api:makeRequest: {"title":"Bad Request","detail":"'-,1.1.1.1' is not of type 'array' - 'arguments'"}

Now, the same example should not show this error.

To test it:

Go to Management/Groups

Given the browser is in wazuh app
When the user navigates to Tools/Api Console
Then the Api Console section will be shown

Precondition 1:
Command: PUT /active-response?agents_list=000 { "arguments": [ "-","1.1.1.1" ], "command":"firewall-drop.sh", "custom": true }

Run this command

Given the browser is Api Console
When the user will run the command according to the Precondition 1
Then the return that will be shown after the command ran will be different to: error: 2021/07/12 15:32:7: wazuh-api:makeRequest: {"title":"Bad Request","detail":"'-,1.1.1.1' is not of type 'array' - 'arguments'"}

Closes: #3457

public/react-services/wz-request.ts

* test(unit-test): Fixing and updating unit-tests. * test(scheduler-job): Fixing suite scheduler-job tests. * test(unit-test): Fixing updating unit-tests. * test(check-result): Fixing uTest of check-result, added error case. * test(unit-test): Skipped uTest with dependency of API. * test(prettier): Applied prettier, redux-mock-store dependency * test(jest): Jest config without dependencies. * test(git-actions): Added workflow for uTest. * test(check-result): Update workflow. * test(git-actions): Updated workflow * test(gitactions): Dependencies for unit test. * test(gitactions): Added coverage-comment * test(gitactions): Changed text to text-summary * test(gitactions): Show summary * test(gitactions): Show summary + added dependencies * test(gitactions): Typo * test(gitactions): Porcents * test(gitactions): Typo * test(gitactions): Testing node version with yarn * test(gitactions): Update * test(gitactions): Update * test(gitactions): testing coverage summary * test(gitactions): testing coverage summary * test(gitactions): fix param github-token * test(gitactions): update * test(gitactions): testing report.json * test(gitactions): final test. * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing * test(actions): testing * test(actions): test with old config jest. * test(actions): set node version for jest * test(actions): testing with bootstrap * test(actions): rollback dependencies * test(actions): rollback * test(groups-main): fixing snapshot test * test(groups-main): added coverage * test(groups-main): fix path * test(groups-main): fix path * test(git-actions): fix script * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * fix(syscollector): Refactor for agents-sections. * fix(syscollector): Clean files. * fix(syscollector): Clean files. * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(actions): test comment coverage * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * fix(actions): add const env Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>

* Implemented new try-catch strategy * Updated context * Added test file and snapshot * Updated CHANGELOG * Requested changes * Removed blank space in message * Updated error title and message Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Techniques and mitre * Resources * Update changelog

* Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Added new try-catch strategy in Management > Configuration * Updated CHANGELOG * Requested changes * doc(changelog): update Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* test(unittest): Updating test. * test(unittest): Updating test.

* fix(syscollector): Added try catch strategy. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * doc(changelog): Updated * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * test(agent-table): Added unit test & fix collectCoverage Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>

* Added try-catc new strategy * Added test file and component snapshot * Updated CHANGELOG * Updating error title and message * Refactor try catch in Management > Statistics (#3429) * Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Merged conflicts * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * merged CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Implemented error-handling * Updated CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Changed the hasChanges state to false after the file is saved succesfully

…ries & directives. (#3474)

Desvelao

review:
Code Review ✅

github-actions · 2021-07-20T14:02:37Z

Jest Test Coverage	%	values
Statements	3.12%	( 1109 / 35594 )
Branches	1.16%	( 324 / 27961 )
Functions	2.02%	( 174 / 8632 )
Lines	3.15%	( 1071 / 34012 )

Desvelao · 2021-07-20T14:03:51Z

Changes

Added the change to changelog

mpRegalado

CR: LGTM ✔️
Testing: LGTM ✔️

ready fixed

compare path

f34ac4f

sortiz1191 added type/bug Bug issue 4.3 labels Jul 13, 2021

sortiz1191 requested a review from a team July 13, 2021 13:50

sortiz1191 self-assigned this Jul 13, 2021

Logs removed

051b6e7

gabiwassan previously requested changes Jul 19, 2021

View reviewed changes

public/react-services/wz-request.ts Outdated Show resolved Hide resolved

Machi3mfl self-assigned this Jul 19, 2021

gabiwassan and others added 22 commits July 19, 2021 17:41

Implement/try catch in Components > Overview (#3442)

78676a5

* Techniques and mitre * Resources * Update changelog

Updating test. (#3470)

60588bb

* test(unittest): Updating test. * test(unittest): Updating test.

fix size api selector and add basic test

e0c7a53

add changelog

9d77820

fix styles in api selector

51a55ce

Refactor try-catch components/add-moludes-data (#3472)

0a32d1a

* Implemented error-handling * Updated CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

Added click outside detector component to euiFlyout

63fd003

Updated CHANGELOG

89978a5

Rebase Changes

b9a904a

Code styling

3553371

Fixed double EuiOverlayMask import

b680a41

Added static child to outside detector and replaced wzoverlaymask

f6c6e6e

Fixed policies-table row click edit and create action

4383eb0

Removed wzOverlayMask imports

794ad66

[Fix] Code overflows over the line numbers in API Console editor (#3439)

4fb7176

Fix error in save before exit prompt in configuration edit (#3460)

0b47904

* Changed the hasChanges state to false after the file is saved succesfully

gabiwassan and others added 4 commits July 19, 2021 17:51

feat(orchestrator): Applied try-catch strategy on controllers & facto…

87a5a7f

…ries & directives. (#3474)

Requested changes

b4bb00c

Merge branch '4.3-7.10' into feature/3457_dev_tools_wrong_body_parse

f8ae8de

changelog: Add PR to changelog

57b97e2

Desvelao approved these changes Jul 20, 2021

View reviewed changes

Machi3mfl removed their assignment Aug 13, 2021

mpRegalado approved these changes Sep 1, 2021

View reviewed changes

frankeros requested a review from gabiwassan September 28, 2021 21:04

CPAlejandro added FE:testing labels Nov 4, 2021

Merge branch '4.3-7.10' into feature/3457_dev_tools_wrong_body_parse

f02b56d

frankeros merged commit 89d1ef4 into 4.3-7.10 Nov 5, 2021

frankeros deleted the feature/3457_dev_tools_wrong_body_parse branch November 5, 2021 12:34

MauGaP mentioned this pull request Nov 30, 2021

Release 4.3.0 - Release Candidate 1 - Kibana UI regression testing #3684

Closed

MauGaP mentioned this pull request Jan 3, 2022

Release 4.3.0 - Release Candidate 2 - Kibana UI regression testing #3730

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrong active-response endpoint parameter from dev tools #3466

Wrong active-response endpoint parameter from dev tools #3466

sortiz1191 commented Jul 13, 2021 •

edited by CPAlejandro

Loading

Desvelao left a comment

github-actions bot commented Jul 20, 2021

Desvelao commented Jul 20, 2021

mpRegalado left a comment •

edited

Loading

Wrong active-response endpoint parameter from dev tools #3466

Wrong active-response endpoint parameter from dev tools #3466

Conversation

sortiz1191 commented Jul 13, 2021 • edited by CPAlejandro Loading

Desvelao left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2021

Desvelao commented Jul 20, 2021

Changes

mpRegalado left a comment • edited Loading

Choose a reason for hiding this comment

sortiz1191 commented Jul 13, 2021 •

edited by CPAlejandro

Loading

mpRegalado left a comment •

edited

Loading