Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/try catch in services #3478

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Conversation

pablomarga
Copy link
Contributor

Hi team,
This PR implement our new error handling strategy on the Public/Services section

Close #3477

@pablomarga pablomarga self-assigned this Jul 14, 2021
@pablomarga pablomarga requested a review from a team July 14, 2021 15:26
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ErrorHandler.handle(error, 'Elasticsearch', { silent: true })
);
$location.path('/blank-screen');
const options = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gabiwassan gabiwassan merged commit c17d7fd into 4.3-7.10 Jul 21, 2021
@gabiwassan gabiwassan deleted the implement/try-catch-services branch July 21, 2021 12:37
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.66% ( 1304 / 35649 )
Branches 1.46% ( 409 / 28087 )
Functions 2.57% ( 221 / 8613 )
Lines 3.7% ( 1260 / 34082 )

gabiwassan added a commit that referenced this pull request Jul 30, 2021
* Impelement try catch in public/services

* Add changelog

* doc(changelog): update

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
* Impelement try catch in public/services

* Add changelog

* doc(changelog): update

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants