Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed api selector toggle from the settings menu #3604

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Removed api selector toggle from the settings menu #3604

merged 4 commits into from
Nov 4, 2021

Conversation

mpRegalado
Copy link
Member

This PR removes the api selector toggle from the settings menu, since it was not actually affecting the state of the selector in the menu bar.

Closes #3335

To test

  • Given the browser is in wazuh app
  • When the user navigates to settings/configuration
  • Then the configuration panel does not show an api selector toggle

Screenshots

Before
Before

After
After

@mpRegalado mpRegalado self-assigned this Sep 15, 2021
@mpRegalado mpRegalado requested a review from a team September 15, 2021 09:09
@mpRegalado mpRegalado linked an issue Sep 15, 2021 that may be closed by this pull request
Api selector toggle does not disable the api selector #3335
Closed
CPAlejandro
CPAlejandro approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!
Testing: LGTM!

asteriscos
asteriscos requested changes Sep 15, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: ✔️
Code looks good to me, except a small comment

public/react-services/app-state.js Outdated Show resolved Hide resolved
asteriscos
asteriscos approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Machi3mfl
Machi3mfl approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@frankeros frankeros changed the base branch from 4.2-7.10 to 4.3-7.10 November 4, 2021 18:13
@frankeros frankeros merged commit 2aec1dc into 4.3-7.10 Nov 4, 2021
@frankeros frankeros deleted the fix/3335-index-pattern-selector branch November 4, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@mpRegalado mpRegalado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api selector toggle does not disable the api selector
5 participants
@mpRegalado @Machi3mfl @asteriscos @CPAlejandro @frankeros