Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related decoder link undefined parameters error #3704

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Related decoder link undefined parameters error #3704

merged 2 commits into from
Dec 1, 2021

Conversation

asteriscos
Copy link
Member

Hi team,

this PR fixes Related decoders file link error when one clicked on it.

Closes #3703

To test it:

  • Go to Managment / Decoders
  • Select the name of a decoder in the table to access Related decoders table
  • In Related decoders table click on a file link and see if it works
  • Repeat the procedure with Rules

Test animation
Peek 2021-12-01 12-47

@asteriscos asteriscos self-assigned this Dec 1, 2021
@CPAlejandro
Copy link
Contributor

CR and Testing in Kibana 7.10.2: LGTM!

@asteriscos asteriscos added the 4.3 label Dec 1, 2021
eze9252
eze9252 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eze9252 eze9252 merged commit 159340b into 4.3-7.10---RC1 Dec 1, 2021
@eze9252 eze9252 deleted the fix/related-decoder-link-error-3703 branch December 1, 2021 16:14
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eze9252 eze9252 eze9252 approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteriscos @CPAlejandro @eze9252