Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug when create filename with spaces and throws a bad error #3724

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fixing bug when create filename with spaces and throws a bad error #3724

merged 2 commits into from
Dec 10, 2021

Conversation

eze9252
Copy link
Contributor

@eze9252 eze9252 commented Dec 10, 2021 •
edited
Loading

Hi team,

This resolves:

  • bug when create filename with spaces and throws a bad error

closes #3716

@eze9252 eze9252 changed the title add toast Fixing bug when create filename with spaces and throws a bad error Dec 10, 2021
@eze9252 eze9252 self-assigned this Dec 10, 2021
@eze9252 eze9252 added the 4.3 label Dec 10, 2021
@eze9252 eze9252 linked an issue Dec 10, 2021 that may be closed by this pull request
Creating decoder with space in name raises error #3716
Closed
Desvelao
Desvelao reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
CR: ✅
Testing: ✅

LGTM!

asteriscos
asteriscos approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@eze9252 eze9252 merged commit 28ecbfe into 4.3-7.10---RC1 Dec 10, 2021
@eze9252 eze9252 deleted the bugfix/add-toast-when-create-filename-with-spaces branch December 10, 2021 16:35
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@asteriscos asteriscos asteriscos approved these changes

Assignees

@eze9252 eze9252

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating decoder with space in name raises error
3 participants
@eze9252 @asteriscos @Desvelao