Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [MODULES] [MITRE Att&ck] Bugs in the details flyouts #3726

Merged
merged 3 commits into from
Dec 16, 2021
Merged

[BUG] [MODULES] [MITRE Att&ck] Bugs in the details flyouts #3726

merged 3 commits into from
Dec 16, 2021

Conversation

Desvelao
Copy link
Member

Description

This PR fixes some problems related to the MITRE Att&ck details flyout:

  • Can't get the tactics of the technique when opening the flyout from Modules/MITRE Att&ck/Events tab and another sections
  • Fixed the redirection to show information about some technique or tacts in the Intelligence tab (Modules/MITRE Att&ck)
    • Replaces references.external_id by external_id. This changed in the response of Wazuh API

Changes

  • Removed openIntelligence component property in some components and moved the functionality to the component.

Tests

  • Open MITRE Att&ck details flyouts should render the data correctly.
  • The links/buttons that open the details flyouts should work.
  • The links of technique/tactic data in the alerts should redirect to Intelligence and show a flyout with information about the selected entity.

Closes #3725

@Desvelao
fix(modules/mitre): error opening MITRE Att&ck details flyout from Ev…
e87a065 
…ents tabhas no information about the tactics

  - Move the request to get the tactics to the `FlyoutTechnique` component
@Desvelao
fix(modules/mitre): Changes in the MITRE Att&ck details flyout
a03a863 
  - `Discover` component:
    - Removed prop `openIntelligence`
    - Removed not used variable and render of a flyout related to MITRE Att&ck
  - `FlyoutTechnique` component:
    - Removed prop `openIntelligence` and use `AppNavigate.navigateToModule`
  - Changed the `references.external_id` property in MITRE Att&ck entities to use `external_id` field.
@Desvelao Desvelao self-assigned this Dec 14, 2021
@Desvelao Desvelao linked an issue Dec 14, 2021 that may be closed by this pull request
[Modules] [MITRE Att&ck] Bugs in the flyouts #3725
Closed
gabiwassan
gabiwassan approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
CR: ✅
Test: ✅

@eze9252 eze9252 merged commit 3d08634 into 4.3-7.10---RC1 Dec 16, 2021
@eze9252 eze9252 deleted the fix/3725-mitre-errors-flyout branch December 16, 2021 15:43
@Desvelao Desvelao added type/bug Bug issue 4.3 labels Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modules] [MITRE Att&ck] Bugs in the flyouts
3 participants
@Desvelao @gabiwassan @eze9252