Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [Deploy agent guide] Add step to start the agent on Windows #3846

Merged
merged 4 commits into from
Feb 16, 2022
Merged

[FEAT] [Deploy agent guide] Add step to start the agent on Windows #3846

merged 4 commits into from
Feb 16, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Feb 15, 2022 •
edited
Loading

Description

This PR adds a step to the deploy new agent guide to starting the agent on Windows.

image

Changes

  • Added the step to start the agent for the Windows guide
  • Reduced the vertical space to the info callout of installing the Windows agent

Test

  • Review the step to start the agent is displayed for the Windows OS

Closes #3843

@Desvelao Desvelao self-assigned this Feb 15, 2022
@Desvelao Desvelao changed the base branch from master to 4.3-7.10 February 15, 2022 11:01
@Desvelao Desvelao requested a review from a team February 15, 2022 11:08
@Desvelao Desvelao added the type/enhancement Enhancement issue label Feb 15, 2022
@Desvelao Desvelao linked an issue Feb 15, 2022 that may be closed by this pull request
Add step to start Windows Service to installation instructions #3843
Closed
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36469 )
Branches 1.61% ( 459 / 28457 )
Functions 2.96% ( 264 / 8904 )
Lines 4.09% ( 1426 / 34865 )

AlexRuiz7
AlexRuiz7 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit 03bc67b into 4.3-7.10 Feb 16, 2022
@Desvelao Desvelao deleted the feat/3843-deploy-agent-guide-add-step-to-start-windows-agent branch February 16, 2022 07:19
@Desvelao Desvelao mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

Assignees

@Desvelao Desvelao

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add step to start Windows Service to installation instructions
2 participants
@Desvelao @AlexRuiz7