Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Tools/Api Console] Parse error when using character on the line start #3877

Merged
merged 2 commits into from
Apr 6, 2022
Merged

[BUG][Tools/Api Console] Parse error when using character on the line start #3877

merged 2 commits into from
Apr 6, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 3, 2022 •
edited
Loading

Description

This PR fixes when the # character is used not at the beginning of the line. This solves a parse error when using the character in the password field to create a new user.

Tests

  • Go to Tools/API Console and set the next query:
POST /security/users
{
  "username": "wazuh_test_user",
  "password": "Abcdef1#"
}

The query shouldn't display the parse error.

Closes #3810

@Desvelao Desvelao added the type/bug Bug issue label Mar 3, 2022
@Desvelao Desvelao self-assigned this Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Jest Test Coverage % values
Statements 4.04% ( 1473 / 36459 )
Branches 1.61% ( 459 / 28444 )
Functions 2.97% ( 264 / 8901 )
Lines 4.09% ( 1425 / 34855 )

@AlexRuiz7 AlexRuiz7 linked an issue Mar 3, 2022 that may be closed by this pull request
[Tools/APIConsole] The # character provokes a Parse error when not used as comment #3810
Closed
2 tasks
Machi3mfl
Machi3mfl approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

yenienserrano
yenienserrano approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@Desvelao Desvelao merged commit a47888b into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/3810-api-console-parse-error-hash-symbol-no-start-line branch April 6, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tools/APIConsole] The # character provokes a Parse error when not used as comment
3 participants
@Desvelao @Machi3mfl @yenienserrano