Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance rework vulnerabilities inventory flyout #3908

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 22, 2022

Hi team,

this PR show all available fields in Discover Details Flyout table. Also fixes the open row icon width in the first column when the table has few columns.
Related PR #3893

To test it:

  • Have some vulnerability alerts
  • Go to Vulnerabilities / Inventory
  • Select a row in the table which has events
  • Open the row to see the details and verify it show all available fields for that event

image

vulnerabilities

@asteriscos asteriscos self-assigned this Mar 22, 2022
@Desvelao
Copy link
Member

thought: There are some files that use the Discover component. Do we want these components to display all the fields or the default subset? If we want to display all fields in all components, maybe we could remove the default subset and the component property to manage when displaying all fields or the subset of them.

@Desvelao
Copy link
Member

Testing

I found a possible problem with the date of scans. See Last partial scan.
image

Maybe we should display an - as in Details panel:
image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36547 )
Branches 1.61% ( 459 / 28475 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34939 )

@Desvelao
Copy link
Member

Testing

I found a possible problem with the date of scans. See Last partial scan. image

Maybe we should display an - as in Details panel: image

This issue was fixed:
image

@Desvelao Desvelao merged commit ba5d5fb into 4.3-7.10 Mar 23, 2022
@Desvelao Desvelao deleted the enhance/rework-vulnerabilities-inventory-flyout branch March 23, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants