Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details flyout date picker #3947

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Details flyout date picker #3947

merged 3 commits into from
Apr 6, 2022

Conversation

yenienserrano
Copy link
Member

Description:

Changed the filter to take the details range and not the global range

Issues Resolved:

Vulnerabilities inventory details flyout date-picker #3932

Test:

  1. Navigate to Integrity monitoring > Inventory or Vulnerabilities > Inventory
  2. Select any row from the table
  3. Change date-picker values
  4. See that the information in the table changes
  5. Navigate to Integrity monitoring > Events
  6. See that the global date-picker did not change

Screenshot:

image
image
image

@yenienserrano yenienserrano requested a review from a team April 5, 2022 09:19
@yenienserrano yenienserrano self-assigned this Apr 5, 2022
@yenienserrano yenienserrano linked an issue Apr 5, 2022 that may be closed by this pull request
Vulnerabilities inventory details flyout date-picker #3932
Closed
asteriscos
asteriscos approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@yenienserrano yenienserrano requested a review from a team April 5, 2022 10:19
Desvelao
Desvelao approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✔️
Test ✔️

@Desvelao Desvelao merged commit f81461f into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/3932-details-flyout-date-picker branch April 6, 2022 11:41
@Desvelao Desvelao added the type/bug Bug issue label Apr 6, 2022
@Desvelao Desvelao mentioned this pull request Apr 6, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36555 )
Branches 1.61% ( 459 / 28476 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34947 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerabilities inventory details flyout date-picker
3 participants
@yenienserrano @asteriscos @Desvelao