Improve the error handler on the configuration save #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing on kibana v7.10.2 OK
|
Desvelao
reviewed
May 3, 2022
| message: errorMessage || error, | ||
| title: `${error.name}: Mitre alerts could not be fetched`, | ||
| message: errorMessage || error, | ||
| title: "The configuration couldn't be saved.", |
There was a problem hiding this comment.
nitpick: The file is saved, but it could be some validation errors. The message could be confusing.
…into fix/configuration-save-error
|
review <ossec_config>
<global>
<jsonout_output>yes</jsonout_output>
<alerts_log>yes</alerts_log>
<alerts_log2 realtime2="yes" >no</alerts_log2>
<!-- Other settings -->and the toast is displayed, but the error is a string, so the conditional block is not modifying the error message. This behavior could be changed due to the chages in the PR #4119. I merged the last changes and it seems to be working.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4071
This PR improves the error handler when the configuration save fails.
This adds better messages that will ease the debugging if the error happens again.
To test
git apply force_save_error.txt'This error has been forced. It is fine.'