Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added authorization prompt in Mitre > Intelligence #4261

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

Machi3mfl
Copy link
Member

Hi Team,
This PR add the AuthorizationPrompt in Mitre Intelligence section

Closes #4243

@Machi3mfl Machi3mfl self-assigned this Jun 14, 2022
@Machi3mfl Machi3mfl requested a review from a team June 14, 2022 18:05
@Machi3mfl Machi3mfl linked an issue Jun 14, 2022 that may be closed by this pull request
@Desvelao
Copy link
Member

review:
test ✔️

Screenshot

image

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.21% ( 1531 / 36387 )
Branches 1.79% ( 505 / 28242 )
Functions 3.29% ( 293 / 8898 )
Lines 4.25% ( 1478 / 34805 )

@Desvelao Desvelao self-requested a review June 16, 2022 06:53
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
code ✔️
test ✔️

Test suite

kibana@kibana_dev:/usr/share/kibana/plugins/wazuh$ yarn test:jest public/components/overview/mitre_attack_intelligence/intelligence.test.tsx
yarn run v1.21.1
$ node scripts/jest public/components/overview/mitre_attack_intelligence/intelligence.test.tsx
 PASS  public/components/overview/mitre_attack_intelligence/intelligence.test.tsx (9.643 s)
  Module Mitre Att&ck intelligence container
    ✓ should render the component if has permissions (58 ms)
    ✓ should render permissions prompt when no has permissions (7 ms)

Screenshot

image

@chantal-kelm chantal-kelm self-requested a review June 16, 2022 13:20
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code ✔️
test ✔️

Screenshot from 2022-06-16 15-36-30

@Desvelao Desvelao merged commit 12fee0e into 4.3-7.10 Jun 17, 2022
@Desvelao Desvelao deleted the feature/4243-mitre-intelligence-rbac branch June 17, 2022 06:49
github-actions bot pushed a commit that referenced this pull request Jun 17, 2022
* Added authorization prompt

* Updated CHANGELOG

* Added mitre intelligence tests

(cherry picked from commit 12fee0e)
github-actions bot pushed a commit that referenced this pull request Jun 17, 2022
* Added authorization prompt

* Updated CHANGELOG

* Added mitre intelligence tests

(cherry picked from commit 12fee0e)
Desvelao pushed a commit that referenced this pull request Jun 17, 2022
#4271)

Added authorization prompt in Mitre > Intelligence (#4261)

* Added authorization prompt

* Updated CHANGELOG

* Added mitre intelligence tests

(cherry picked from commit 12fee0e)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Desvelao pushed a commit that referenced this pull request Jun 17, 2022
…ence (#4272)

Added authorization prompt in Mitre > Intelligence (#4261)

* Added authorization prompt

* Updated CHANGELOG

* Added mitre intelligence tests

(cherry picked from commit 12fee0e)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inappropriate permissions' handling in MITRE intelligence section
3 participants