-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation links to point to correct version instead of current #4301
Fix documentation links to point to correct version instead of current #4301
Conversation
Created service to generate the web documentation URLs Fixed not found URLs Changed some link texts Refactored some prompts to match other similar elements Updated the script to generate the API info that create the URLs for the endpoints
9c23f6c
to
bbcf407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Test: ✔️
Solves the title overflow
Solves title overflow
Some of the documenatation links titles were outdated or too long, causing the title to overflow. These titles have been updated to the titltes on their Wazuh documentation page. Also, a new link has been aded to the Docker Listener section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
- Code: ✔️
- Test: ✔️
@@ -1,190 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this file deleted?
...ic/controllers/management/components/management/configuration/client-buffer/client-buffer.js
Outdated
Show resolved
Hide resolved
|
* feat: web documentation URLs point to plugin short version Created service to generate the web documentation URLs Fixed broken links Changed some link texts Refactored some prompts to match other similar elements Updated the script to generate the API info that create the URLs for the endpoints * changelog: add PR entries * fix: replaced the title for agent enrollment link * feat: added tests to webDocumentationLink function * Change documentation title of Wazuh agent enrollment * Update documentation links titles Some documentation links titles were outdated or too long, causing the title to overflow. These titles have been updated to the titles on their Wazuh documentation page. Also, a new link has been added to the Docker Listener section. Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 463665e)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4301-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 463665ef2a01ace783162adea48952e6bfe3a54d
# Push it to GitHub
git push --set-upstream origin backport-4301-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd Then, create a pull request where the |
…ion (#4304) Web documentation URLs point to plugin short version (#4301) * feat: web documentation URLs point to plugin short version Created service to generate the web documentation URLs Fixed broken links Changed some link texts Refactored some prompts to match other similar elements Updated the script to generate the API info that create the URLs for the endpoints * changelog: add PR entries * fix: replaced the title for agent enrollment link * feat: added tests to webDocumentationLink function * Change documentation title of Wazuh agent enrollment * Update documentation links titles Some documentation links titles were outdated or too long, causing the title to overflow. These titles have been updated to the titles on their Wazuh documentation page. Also, a new link has been added to the Docker Listener section. Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 463665e) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
* feat: web documentation URLs point to plugin short version Created service to generate the web documentation URLs Fixed broken links Changed some link texts Refactored some prompts to match other similar elements Updated the script to generate the API info that create the URLs for the endpoints * changelog: add PR entries * fix: replaced the title for agent enrollment link * feat: added tests to webDocumentationLink function * Change documentation title of Wazuh agent enrollment * Update documentation links titles Some documentation links titles were outdated or too long, causing the title to overflow. These titles have been updated to the titles on their Wazuh documentation page. Also, a new link has been added to the Docker Listener section. Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 463665e)
…ersion (#4305) Web documentation URLs point to plugin short version (#4301) * feat: web documentation URLs point to plugin short version Created service to generate the web documentation URLs Fixed broken links Changed some link texts Refactored some prompts to match other similar elements Updated the script to generate the API info that create the URLs for the endpoints * changelog: add PR entries * fix: replaced the title for agent enrollment link * feat: added tests to webDocumentationLink function * Change documentation title of Wazuh agent enrollment * Update documentation links titles Some documentation links titles were outdated or too long, causing the title to overflow. These titles have been updated to the titles on their Wazuh documentation page. Also, a new link has been added to the Docker Listener section. Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 463665e) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Description
This PR changes the web documentation URLs to point using the plugin short version instead of
current
.Closes #4294 #4296.
Changes
endpoints
Screenshots
Test
Manual tests
Automatic tests
yarn test:jest common/services/web_documentation.test.ts
Expected result: