Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Manager/Ruleset #446

Merged
merged 8 commits into from
May 10, 2018
Merged

Improvements for Manager/Ruleset #446

merged 8 commits into from
May 10, 2018

Conversation

JuanjiJG
Copy link
Contributor

Hello team,

This pull requests adds several enhancements and bugfixes for the Manager/Ruleset tab, such as:

  • New colour palette for regex, order and rule description arguments.
  • Added return to List view on Ruleset button while on Detail view.
  • Fixed line height on all table headers.
  • Removed unused, old code from Ruleset controllers.

Best regards,
Juanjo

@JuanjiJG JuanjiJG self-assigned this May 10, 2018
@JuanjiJG JuanjiJG requested a review from havidarou May 10, 2018 11:20
@JuanjiJG JuanjiJG mentioned this pull request May 10, 2018
Closed
4 tasks
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 532a166 into 3.2 May 10, 2018
@havidarou havidarou deleted the 3.2-ruleset-improvements branch May 10, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havidarou havidarou Awaiting requested review from havidarou

Assignees

@JuanjiJG JuanjiJG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuanjiJG @havidarou