Fix Flyout component in Wazuh Dashboard 2.x #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdiazlo
changed the title
AlexRuiz7
changed the title
11 tasks
Desvelao
reviewed
Oct 10, 2022
yenienserrano
requested changes
Oct 13, 2022
|
In the test I noticed that when you are editing something and you click outside the flyout it closes the flyout, and before when you were editing something, and you clicked outside the flyout a warning modal appeared that it was going to close if you wanted to continue or not the closing.
|
Mayons95
approved these changes
Oct 13, 2022
4 tasks
11 tasks
yenienserrano
requested review from
yenienserrano
and removed request for
yenienserrano
There was a problem hiding this comment.
Reverted changes due to a bug in Elastic EUI, added back the component to handle the flyout and added the closing functions.
More details here.
|
Back to draft due to #4597 (comment) |
AlexRuiz7
suggested changes
Oct 19, 2022
Mayons95
approved these changes
Oct 19, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrong behavior from the Flyout component in Wazuh Dashboard 2.x.
Issues Resolved
This PR fixes the flyout behavior. The
wz-flyoutwas removed and replaced by the native EuiFlyout.Closes #4597
Test
Navigate to the following sections and test the flyout behavior. Click and explore inner content.
Defined on #4597 (comment)
Check List
yarn test:jest