Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mismatch error message when method not allowed #4964

Merged
merged 8 commits into from
Dec 22, 2022

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Dec 6, 2022

Description

This PR adds a message when the API returns a Method Not Allowed to let the user know that the error may be related to a version mismatch between the App and the Server.

Issues Resolved

#4915

Evidence

image

Test

Scenario: have an environment with Wazuh server <=4.3 and Wazuh App >=4.4
When the user navigates to Wazuh and the healthcheck is done
Then an error should appear in the first check, and a message telling that may be related to a version mismatch should appear at the bottom.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti requested a review from a team as a code owner December 6, 2022 16:11
@Tostti Tostti changed the title Modify error message Add mismatch error message when method not allowed Dec 6, 2022
@Tostti Tostti linked an issue Dec 6, 2022 that may be closed by this pull request
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

Solve the commented problems.

Changelog is missing.

@Tostti Tostti requested a review from Desvelao December 20, 2022 19:01
Machi3mfl
Machi3mfl previously approved these changes Dec 22, 2022
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Code 🟢

Test

Scenario Result
1 🟢
Scenario 1 🟢

An API in 4.3.x
image

An API down and an API up 4.3.x
image

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.74% ( 3234 / 37007 )
Branches 4.57% ( 1314 / 28748 )
Functions 7.59% ( 696 / 9166 )
Lines 8.81% ( 3121 / 35433 )

@asteriscos asteriscos merged commit fe61c0f into 4.4-7.10 Dec 22, 2022
@asteriscos asteriscos deleted the fix/add-mismatch-message-when-API-error branch December 22, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana mismatch version error is not displayed
5 participants