Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change anchor to EuiLink #5298

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Change anchor to EuiLink #5298

merged 6 commits into from
Mar 20, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 15, 2023

Description

Change the anchors to EuiLink and those that are links to external sites add the external property, target='_blank' and rel="noopener noreferrer"

Issues Resolved

Evidence

screenshot ![agents prev](https://user-images.githubusercontent.com/63758389/225378860-21223897-ae38-489b-8b5d-3ccf35e6f9d9.png)

blank

cluster

never_connecte

register_agent_2

register_agents

troble

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Mar 16, 2023
@yenienserrano yenienserrano linked an issue Mar 16, 2023 that may be closed by this pull request
8 tasks
@yenienserrano yenienserrano marked this pull request as ready for review March 16, 2023 16:10
@yenienserrano yenienserrano requested a review from a team as a code owner March 16, 2023 16:10
@Machi3mfl
Copy link
Member

I've resolved the conflicts in the register-agent.js component and added a EuiLink missed.
Check this commit fad3e30

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.82% ( 3260 / 36932 )
Branches 4.52% ( 1296 / 28650 )
Functions 7.66% ( 701 / 9145 )
Lines 8.88% ( 3143 / 35366 )

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yenienserrano yenienserrano merged commit cf4e214 into 4.5 Mar 20, 2023
@yenienserrano yenienserrano deleted the fix-5038-chagne-link-to-euilink branch March 20, 2023 08:49
@github-actions
Copy link
Contributor

The backport to 4.5-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5298-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf4e214bce5bdce54b0927ee70876ac73d17f131
# Push it to GitHub
git push --set-upstream origin backport-5298-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10

Then, create a pull request where the base branch is 4.5-7.10 and the compare/head branch is backport-5298-to-4.5-7.10.

@github-actions
Copy link
Contributor

The backport to 4.5-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5298-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf4e214bce5bdce54b0927ee70876ac73d17f131
# Push it to GitHub
git push --set-upstream origin backport-5298-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16

Then, create a pull request where the base branch is 4.5-7.16 and the compare/head branch is backport-5298-to-4.5-7.16.

yenienserrano added a commit that referenced this pull request Mar 20, 2023
* Change some anchor to euiLink

* Change anchor to euiLink

* Change register-agent euilink

* Add changelog

---------

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
(cherry picked from commit cf4e214)
yenienserrano added a commit that referenced this pull request Mar 20, 2023
* Change some anchor to euiLink

* Change anchor to euiLink

* Change register-agent euilink

* Add changelog

---------

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
(cherry picked from commit cf4e214)
yenienserrano added a commit that referenced this pull request Mar 20, 2023
Change `anchor` to `EuiLink` (#5298)

* Change some anchor to euiLink

* Change anchor to euiLink

* Change register-agent euilink

* Add changelog

---------

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
(cherry picked from commit cf4e214)
yenienserrano added a commit that referenced this pull request Mar 20, 2023
* Change `anchor` to `EuiLink` (#5298)

* Change some anchor to euiLink

* Change anchor to euiLink

* Change register-agent euilink

* Add changelog

---------

Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
(cherry picked from commit cf4e214)

* Remove the code of another PR

* Update wz-blank-screen.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rel="noopener noreferrer" in documentation links
3 participants