-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change anchor
to EuiLink
#5298
Change anchor
to EuiLink
#5298
Conversation
I've resolved the conflicts in the register-agent.js component and added a EuiLink missed. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5298-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf4e214bce5bdce54b0927ee70876ac73d17f131
# Push it to GitHub
git push --set-upstream origin backport-5298-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5298-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf4e214bce5bdce54b0927ee70876ac73d17f131
# Push it to GitHub
git push --set-upstream origin backport-5298-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16 Then, create a pull request where the |
* Change `anchor` to `EuiLink` (#5298) * Change some anchor to euiLink * Change anchor to euiLink * Change register-agent euilink * Add changelog --------- Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com> (cherry picked from commit cf4e214) * Remove the code of another PR * Update wz-blank-screen.js
Description
Change the anchors to EuiLink and those that are links to external sites add the external property, target='_blank' and rel="noopener noreferrer"
Issues Resolved
rel="noopener noreferrer"
in documentation links #5038Evidence
screenshot
![agents prev](https://user-images.githubusercontent.com/63758389/225378860-21223897-ae38-489b-8b5d-3ccf35e6f9d9.png)Check List
yarn test:jest