Remove repeated and unnecessary requests in security section #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenienserrano
changed the title
|
TestLegend: UI
Details 🟢 Check that there are no repeated requests in the `user` tabChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that there are no repeated requests in the `roles` tabChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that there are no repeated requests in the `policies` tabChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that there are no repeated requests in the `roles mapping` tabChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 the request `/security/actions` in the `policies` should not be doneChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 the request `/security/resources` in the `policies` should not be doneChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 the request `/security/policies` in `create policies` should not be doneChrome - 🟢 Firefox - ⚫ Safari - ⚫ |
Desvelao
approved these changes
May 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2023
* Remove repeated request * Remove deprecated code and request * Remove deprecated code and request in create-policy * Add changelog (cherry picked from commit 9fcea14)
This was referenced May 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2023
* Remove repeated request * Remove deprecated code and request * Remove deprecated code and request in create-policy * Add changelog (cherry picked from commit 9fcea14)
AlexRuiz7
pushed a commit
that referenced
this pull request
May 30, 2023
…ity section (#5511) Remove repeated and unnecessary requests in security section (#5500) * Remove repeated request * Remove deprecated code and request * Remove deprecated code and request in create-policy * Add changelog (cherry picked from commit 9fcea14) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
AlexRuiz7
pushed a commit
that referenced
this pull request
May 30, 2023
…ity section (#5510) Remove repeated and unnecessary requests in security section (#5500) * Remove repeated request * Remove deprecated code and request * Remove deprecated code and request in create-policy * Add changelog (cherry picked from commit 9fcea14) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove repeated and unnecessary requests in security section, that was being caused by the way in which it was controlled which view was rendered, (by the url and a state).
Issues Resolved
Evidence
Screenshots
Users
Roles
Policies
Create policies
Roles mapping
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
usertabrolestabpoliciestabroles mappingtab/security/actionsin thepoliciesshould not be done/security/resourcesin thepoliciesshould not be done/security/policiesincreate policiesshould not be doneDetails
⚫ Check that there are no repeated requests in the `user` tab
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that there are no repeated requests in the `roles` tab
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that there are no repeated requests in the `policies` tab
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that there are no repeated requests in the `roles mapping` tab
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ the request `/security/actions` in the `policies` should not be done
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ the request `/security/resources` in the `policies` should not be done
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ the request `/security/policies` in `create policies` should not be done
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest