Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when using chinese characters in username #6076

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Fix error when using chinese characters in username #6076

merged 3 commits into from
Nov 1, 2023

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Oct 30, 2023

Description

This PR aims to solve an issue detected when the Dashboard username contains chinese characters.

Issues Resolved

#6068

Evidence

image

Test

Using an environment with a real manager:

  • Create an internal user with chinese characters. For example Test 证明. Assign admin permissions
  • Map the internal user with the admin role in the Wazuh Plugin
  • Log in with the new user
  • Navigate in the app and verify that no errors are shown and the app works as expected

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Oct 30, 2023
@Tostti Tostti linked an issue Oct 30, 2023 that may be closed by this pull request
User name with Chinese characters fails Wazuh API authorization #6068
Closed
@Tostti Tostti marked this pull request as ready for review October 30, 2023 15:50
@Tostti Tostti requested a review from a team as a code owner October 30, 2023 15:50
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.71% ( 4041 / 34487 )
Branches 7.96% ( 1855 / 23291 )
Functions 11.21% ( 925 / 8246 )
Lines 11.89% ( 3929 / 33026 )

asteriscos
asteriscos approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@lucianogorza lucianogorza self-requested a review November 1, 2023 14:08
@lucianogorza
Copy link
Contributor

CR 🟢

Test 🟢

image

@Tostti Tostti merged commit c90a6ae into 4.7.1 Nov 1, 2023
2 checks passed
@Tostti Tostti deleted the 6068-fix-error-username-with-chinese-characters branch November 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Tostti Tostti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User name with Chinese characters fails Wazuh API authorization
3 participants
@Tostti @lucianogorza @asteriscos