Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing columns in the agents table of groups #6184

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix missing columns in the agents table of groups #6184

merged 2 commits into from
Nov 30, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 30, 2023 •
edited
Loading

Description

This pull request fixes the missing columns in the agents table of Groups section.

Issues Resolved

#6183

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the agents table of a group displays the columns: ID, Name, IP address, Operating System, Version, Status and Actions ⚫ ⚫ ⚫

Details

⚫ Ensure the agents table of a group displays the columns: ID, Name, IP address, Operating System, Version, Status and Actions

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner November 30, 2023 15:16
@Desvelao Desvelao self-assigned this Nov 30, 2023
@Desvelao Desvelao linked an issue Nov 30, 2023 that may be closed by this pull request
Missing columns in the agents table of a group #6183
Closed
@github-actions GitHub Actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34494 )
Branches 7.95% ( 1853 / 23289 )
Functions 11.27% ( 930 / 8251 )
Lines 11.91% ( 3937 / 33034 )

yenienserrano
yenienserrano approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@jbiset jbiset self-requested a review November 30, 2023 16:43
jbiset
jbiset approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Evidence

Chrome 🟢

image

Firefox 🟢

image

@asteriscos asteriscos merged commit 93278eb into 4.7.1 Nov 30, 2023
2 checks passed
@asteriscos asteriscos deleted the fix/6183-missing-columns-agents-table-group branch November 30, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing columns in the agents table of a group
4 participants
@Desvelao @jbiset @yenienserrano @asteriscos