Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hostname board serial fields to agent inventory #6191

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Add hostname board serial fields to agent inventory #6191

merged 6 commits into from
Dec 11, 2023

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Dec 5, 2023 •
edited
Loading

Description

Agent > Inventory shows hostname and board serial fields

Issues Resolved

#6190

Evidence

image

Test

  • Go to Agent > Inventory and check that shows the expected result

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz requested a review from a team as a code owner December 5, 2023 08:48
@JuanGarriuz JuanGarriuz linked an issue Dec 5, 2023 that may be closed by this pull request
Add hostname and board_serial information in the agent inventory #6190
Closed
2 tasks
@JuanGarriuz JuanGarriuz changed the base branch from master to 4.7.2 December 5, 2023 08:50
Desvelao
Desvelao requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: fix the tests and add the entry to the changelog

Desvelao
Desvelao previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Test evidences:
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34494 )
Branches 7.96% ( 1855 / 23297 )
Functions 11.27% ( 930 / 8251 )
Lines 11.91% ( 3937 / 33034 )

asteriscos
asteriscos approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Evidence

image

@asteriscos asteriscos merged commit 3cc0cd4 into 4.7.2 Dec 11, 2023
2 checks passed
@asteriscos asteriscos deleted the feat/6190-add-hostname-board_serial-fields-to-agent-inventory branch December 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Desvelao Desvelao Desvelao left review comments

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hostname and board_serial information in the agent inventory
3 participants
@JuanGarriuz @asteriscos @Desvelao